fix: INFOPORTAL-9868: Support content_lock 3.x new method signatures #32
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petarbasic
approved these changes
Mar 12, 2025
fago
reviewed
Nov 4, 2025
| $lock_service_param_type = $methodParams[0]->getType()->getName(); | ||
| } | ||
| // First param is an Entity in version 3.x. | ||
| if ($node instanceof $lock_service_param_type) { |
Contributor
There was a problem hiding this comment.
is this acutally still needed to be able to delete an entity? it seems silly to me that entity deletion would require the lock to be released first?!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see updated methods https://git.drupalcode.org/project/content_lock/-/commit/41c9269b7b874fcebebb8449e893fa2b0954b2b1#f8086afaa68f501d296346aa027d8a7c4a02ed5d_347_252