Merged
Conversation
7bb918c to
3e22e92
Compare
Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
3e22e92 to
9a90860
Compare
Contributor
Author
|
@MiguelBarro #111 has a bunch of fixes as well, entirely non-controversial, I needed them to get xtypes working with my setup on ubuntu 22.04. |
|
On Ubuntu 22.04 running ROS2 humble LTS, I can confirm this fixes compilation with g++ 11.3.0. I agree with the fix by @russkel. Since this is a trivial change, can it be merged? Reference: https://en.cppreference.com/w/cpp/types/numeric_limits |
Ryanf55
added a commit
to Ryanf55/Integration-Service
that referenced
this pull request
Feb 23, 2023
* Fix for eProsima#181 * Updates hash to use eProsima/xtypes#108 Signed-off-by: Ryan Friedman <ryanfriedman5410+github@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I was unable to compile xtypes with GCC 11 on Ubuntu 22.04 without implicitly adding this include to
UnionTypes.hpp.Perhaps Ubuntu 22.04 needs to be added to the CI test systems.