Open
Conversation
russkel
force-pushed
the
cxx20-fixes
branch
2 times, most recently
from
acaf127 to
d4ae900
Compare
Merged
Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
place Signed-off-by: Russ Webber <russ.webber@greenroomrobotics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the errors in #109.
Also includes #108 which should be merged first I guess. Then this can be rebased&merged.
I was not sure if casting the
char16_t/wchar_tto ints is good enough for the string output. Perhaps someone could advise?I also pinned cpp-peglib to what was the current version at the time because the API changed. I have updated to reflect the newer API but I don't think it should be set to trunk in case this happens again and break the build.