Skip to content

Feature/submodule tridap#99

Open
s0nofab1t wants to merge 3 commits into
eclipse-adore:developfrom
s0nofab1t:feature/submodule-tridap
Open

Feature/submodule tridap#99
s0nofab1t wants to merge 3 commits into
eclipse-adore:developfrom
s0nofab1t:feature/submodule-tridap

Conversation

@s0nofab1t

Copy link
Copy Markdown
Contributor

Description

Added new submodule adore-tridap. This submodule will bundle all modules providing access to (REST) interfaces of TRIDAP. For now, it comprises of a module for map downloading (used in adore_map), and a preliminary module for nowcast querying.

Type of Change

Please merge the related PR for adore_map first - that way I can update the hash for adore_map in this PR here.

  • New feature (non-breaking change which adds functionality)
  • Documentation update (adds or updates documentation)
  • Refactor (non-breaking change for code readability/structure)

Checklist

  • I have performed a self-review of my own code.
  • I have signed and submitted the Eclipse Foundation Contributors Agreement: https://www.eclipse.org/legal/eca/.
  • My last commit was made with the --signoff flag as required by the Eclipse Foundation.
  • I have commented my code, particularly in hard-to-understand areas and provided a README.md when necessary.
  • I have added tests that prove my fix is effective or that my feature works.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so others can reproduce.

  • Unit tests: In the ADORe CLI, I ran the google tests under adore/ros2_workspace/build/adore_map/test/ and under adore/ros2_workspace/build/adore_tridap/test/. Worked.
  • Standalone test programs under adore/ros2_workspace/src/adore_test_programs/adore_map_downloader_test and ros2_workspace/src/adore_test_programs/adore_nowcast_test: Ran them (see the README.md in both directories for instructions on how to run them). Worked.

Test Configuration:

  • OS: Ubuntu Noble Numbat
  • Docker Version: 29.3.1

Screenshots (if applicable)

Include any relevant screenshots or videos to demonstrate the feature/fix.

Related Issues

PR for adore_map is related - as has been said before, it would be great if you could merge this related PR before merging this PR here.

Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Signed-off-by: s0nofab1t <ruediger.ebendt@dlr.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant