Skip to content

Update go-libaudit and remove close/draining code#43352

Merged
fearful-symmetry merged 13 commits intoelastic:mainfrom
fearful-symmetry:update-go-libaudit-close
Mar 28, 2025
Merged

Update go-libaudit and remove close/draining code#43352
fearful-symmetry merged 13 commits intoelastic:mainfrom
fearful-symmetry:update-go-libaudit-close

Conversation

@fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Mar 18, 2025

Proposed commit message

This is a continuation of elastic/go-libaudit#176

This is pretty simple, all we're doing besides updating the dependency is removing the old closeAuditClient() code.

Putting this in draft while I tinker with the setPID() method in light of the changes made to go-libaudit.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added bug Team:Security-Linux Platform Linux Platform Team in Security Solution labels Mar 18, 2025
@fearful-symmetry fearful-symmetry self-assigned this Mar 18, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 18, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@fearful-symmetry fearful-symmetry marked this pull request as ready for review March 21, 2025 14:37
@fearful-symmetry fearful-symmetry requested review from a team as code owners March 21, 2025 14:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@fearful-symmetry fearful-symmetry merged commit 5da0bd1 into elastic:main Mar 28, 2025
158 checks passed
@fearful-symmetry fearful-symmetry added the backport-8.19 Automated backport to the 8.19 branch label Oct 15, 2025
mergify bot pushed a commit that referenced this pull request Oct 15, 2025
* update go-libaudit

* notice

* add tests, refactor setPID retry

* improve docs:

* add eintr check

* clean up tests

* fix error message

* linter

(cherry picked from commit 5da0bd1)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
fearful-symmetry added a commit that referenced this pull request Oct 22, 2025
…code (#47128)

* Update go-libaudit and remove close/draining code (#43352)

* update go-libaudit

* notice

* add tests, refactor setPID retry

* improve docs:

* add eintr check

* clean up tests

* fix error message

* linter

(cherry picked from commit 5da0bd1)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum

* fix cherry-pick

---------

Co-authored-by: Alex K <8418476+fearful-symmetry@users.noreply.github.com>
Co-authored-by: fearful-symmetry <alexpkristiansen@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auditbeat backport-8.19 Automated backport to the 8.19 branch bug Team:Security-Linux Platform Linux Platform Team in Security Solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants