Draft
Conversation
💚 Build Succeeded
cc @jsoriano |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semantic validators read and parse the same files multiple times. For example we have ~9 semantic validators that parse fields files, what in some cases takes most of the validation time.
I discussed about this problem to copilot/claude, and we decided on some refactors, that basically Claude implemented.
The changes are basically adding caches at the file system level, and when unmarshalling and getting values from files.
The average improvement when tested with the packages in the integrations repository is around 22%, with 88% reduction in unmarshall operations (as they are cached), and around 16% reduction in total allocations and GC activity.
Cache entries never expire, but the cache itself only lives during the validation, and then is cleaned up by the GC.