Fix #8894 bug, crashing while listening to notifications#9140
Open
progician wants to merge 1 commit into
Open
Conversation
…vice The foreground notification listener service eventually times out, as Android 12+ does not allow applications running in the foreground indefinitely. The service than gets interrupted and runs into an exception, which never gets properly caught and so it ends up with the application crashing. While this change doesn't fix the underlying issue, that the foreground notification listener service cannot run any longer, at least it doesn't crash the application. I do wonder, however, if the whole foreground notification listener is not really viable in this form.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Content
Captures exceptions and logs them coming from the foreground notification listener service.
Motivation and context
The foreground notification listener service eventually times out, as Android 12+ does not allow applications running in the foreground indefinitely. The service than gets interrupted and runs into an exception, which never gets properly caught and so it ends up with the application crashing.
While this change doesn't fix the underlying issue, that the foreground notification listener service cannot run any longer, at least it doesn't crash the application.
I do wonder, however, if the whole foreground notification listener is not really viable in this form.
Tests
Tested devices
Checklist