Skip to content

Fix #8894 bug, crashing while listening to notifications #9140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
progician wants to merge 1 commit into
base: develop
Choose a base branch
from
+9 −1
Open

Fix #8894 bug, crashing while listening to notifications #9140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion vector-app/src/fdroid/java/im/vector/app/fdroid/service/GuardAndroidService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import dagger.hilt.android.AndroidEntryPoint
import im.vector.app.core.services.VectorAndroidService
import im.vector.app.features.notifications.NotificationUtils
import im.vector.lib.strings.CommonStrings
import timber.log.Timber
import javax.inject.Inject

/**
Expand All @@ -27,7 +28,14 @@ class GuardAndroidService : VectorAndroidService() {
override fun onStartCommand(intent: Intent?, flags: Int, startId: Int): Int {
val notificationSubtitleRes = CommonStrings.notification_listening_for_notifications
val notification = notificationUtils.buildForegroundServiceNotification(notificationSubtitleRes, false)
startForeground(NotificationUtils.NOTIFICATION_ID_FOREGROUND_SERVICE, notification)
try {
startForeground(NotificationUtils.NOTIFICATION_ID_FOREGROUND_SERVICE, notification)
} catch (e: Exception) {
Timber.e("## Sync: Failed to start GuardAndroidService as foreground service: ${e.message}")
// Stop the service if we can't start it as foreground
stopSelf()
return START_NOT_STICKY
}
return START_STICKY
}
}