Skip to content

Room list: add custom section creation in SC#33138

Merged
florianduros merged 6 commits intodevelopfrom
florianduros/create-section-views
Apr 16, 2026
Merged

Room list: add custom section creation in SC#33138
florianduros merged 6 commits intodevelopfrom
florianduros/create-section-views

Conversation

@florianduros
Copy link
Copy Markdown
Member

@florianduros florianduros commented Apr 14, 2026

Task #32455

This PR adds in the shared component:

  • An entry in the room list header and in the room list item menu to create a new section
  • Add a toast to room list
  • Replace the compose icon by a plus icon in the room list header when enabled (only when sections are enabled)
  • Fix an issue where the vitest tests are failing when using new icons

The vms disable the custom section until their proper implementation in #33155 in order to keep the PR size reasonable.

@florianduros florianduros added the T-Task Tasks for the team like planning label Apr 14, 2026
@florianduros florianduros force-pushed the florianduros/create-section-views branch 2 times, most recently from c922b7f to 8838c3c Compare April 14, 2026 12:56
@florianduros florianduros force-pushed the florianduros/create-section-views branch from 8838c3c to 3169746 Compare April 14, 2026 13:03
@florianduros florianduros force-pushed the florianduros/create-section-views branch from f9daafe to fd3ada5 Compare April 14, 2026 13:15
@florianduros florianduros force-pushed the florianduros/create-section-views branch from fd3ada5 to 3aefa86 Compare April 14, 2026 13:33
@florianduros florianduros force-pushed the florianduros/create-section-views branch from 3aefa86 to dfd3fb8 Compare April 14, 2026 14:07
@florianduros florianduros force-pushed the florianduros/create-section-views branch from dfd3fb8 to 43a501c Compare April 14, 2026 15:12
@florianduros florianduros force-pushed the florianduros/create-section-views branch from 43a501c to 48f08d7 Compare April 14, 2026 15:17
@florianduros florianduros force-pushed the florianduros/create-section-views branch from 48f08d7 to 517a94a Compare April 15, 2026 10:36
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a missing separator

@florianduros florianduros changed the title Add custom section creation in SC Room list: add custom section creation in SC Apr 15, 2026
@florianduros florianduros marked this pull request as ready for review April 16, 2026 09:59
@florianduros florianduros requested a review from a team as a code owner April 16, 2026 09:59
@florianduros florianduros requested review from dbkr and t3chguy April 16, 2026 09:59

import React, { type ComponentType, type JSX } from "react";
import { Toast } from "@vector-im/compound-web";
import { type MouseEventHandler } from "react";
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sonar probably has a point here

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh right!

@florianduros florianduros added this pull request to the merge queue Apr 16, 2026
Merged via the queue into develop with commit d7f5546 Apr 16, 2026
58 checks passed
@florianduros florianduros deleted the florianduros/create-section-views branch April 16, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-Task Tasks for the team like planning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants