Room list: add custom section creation#33155
Open
florianduros wants to merge 10 commits intodevelopfrom
Open
Conversation
florianduros
added
T-Enhancement
T-Feature
florianduros
force-pushed
the
florianduros/create-section-vms
branch
from
9fdf6f9 to
58b8ecc
Compare
florianduros
force-pushed
the
florianduros/create-section-vms
branch
from
0f91eb8 to
16ef56c
Compare
florianduros
force-pushed
the
florianduros/create-section-vms
branch
from
16ef56c to
8f12de2
Compare
florianduros
force-pushed
the
florianduros/create-section-vms
branch
from
8f12de2 to
00a2057
Compare
florianduros
force-pushed
the
florianduros/create-section-vms
branch
from
00a2057 to
8262703
Compare
florianduros
force-pushed
the
florianduros/create-section-vms
branch
from
8262703 to
c03cdd3
Compare
dbkr
approved these changes
Apr 16, 2026
| */ | ||
| private loadCustomSections(): void { | ||
| const orderedCustomSections = SettingsStore.getValue("RoomList.OrderedCustomSections"); | ||
| this.sortedTags = [DefaultTagID.Favourite, ...orderedCustomSections, CHATS_TAG, DefaultTagID.LowPriority]; |
Member
There was a problem hiding this comment.
Minor cleanliness but maybe put the generation of sortedTags into one place and call it both from here and the ctor?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task #32455
Require #33138 for the views
The PR add the custom section creation to EW: