Merged
Conversation
934be3e to
f3962cd
Compare
86084e2 to
db6c430
Compare
db6c430 to
a667a97
Compare
zeebok
approved these changes
Jun 2, 2025
Contributor
zeebok
left a comment
There was a problem hiding this comment.
Not sure if @danirabbit has any opinion on the default shortcuts but the code looks good to me
Contributor
|
I'm going to merge It because @lenemter removed the default shortcuts, I think we're good to Go :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our own replacement for gsd-media-keys for launching apps. If an app is not running, launch it, otherwise focus it or shake it like the dock does.
Closes elementary/gala#1119
Closes elementary/settings-keyboard#358
Todo:
Make settings-keyboard branchAdd settings-daemon application launcher support settings-keyboard#536Wait for OS 9 I guessAdded migration path