Skip to content

Add settings-daemon application launcher support#536

Merged
danirabbit merged 7 commits intomainfrom
lenemter/add-system-daemon-applications
Jun 10, 2025
Merged

Add settings-daemon application launcher support#536
danirabbit merged 7 commits intomainfrom
lenemter/add-system-daemon-applications

Conversation

@lenemter
Copy link
Copy Markdown
Member

@lenemter lenemter commented May 17, 2025

Requires elementary/settings-daemon#190

Fixes #161
Closes #19
Fixes #525
Closes #74

image

image

@lenemter lenemter force-pushed the lenemter/add-system-daemon-applications branch 3 times, most recently from 7eed570 to bf27d5a Compare May 18, 2025 07:06
Comment thread src/Shortcuts/Widgets/CustomShortcutListBox.vala Outdated
@lenemter lenemter force-pushed the lenemter/add-system-daemon-applications branch 4 times, most recently from 7ec090a to 6aef3f3 Compare May 18, 2025 08:10
@lenemter lenemter marked this pull request as ready for review May 18, 2025 08:11
@lenemter lenemter added this to OS 9 May 18, 2025
@lenemter lenemter moved this to Needs Review in OS 9 May 18, 2025
@lenemter lenemter requested review from a team and danirabbit May 18, 2025 08:11
@lenemter
Copy link
Copy Markdown
Member Author

Added support for app actions.

@lenemter lenemter force-pushed the lenemter/add-system-daemon-applications branch 4 times, most recently from c3411b2 to f6fa878 Compare May 18, 2025 14:07
@lenemter lenemter force-pushed the lenemter/add-system-daemon-applications branch from f6fa878 to ff8a550 Compare May 18, 2025 14:08
Copy link
Copy Markdown
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! A few comments

Comment thread src/Shortcuts/Widgets/AppChooser.vala
Comment thread src/Shortcuts/Widgets/AppChooser.vala Outdated
Comment thread src/Shortcuts/Widgets/AppChooser.vala Outdated
Comment thread src/Shortcuts/Widgets/AppChooser.vala Outdated
@lenemter lenemter requested a review from danirabbit May 19, 2025 21:38
@leonardo-lemos
Copy link
Copy Markdown
Collaborator

@danirabbit hey Dani, can we get a re-review here, please?

@danirabbit danirabbit merged commit 1abf8da into main Jun 10, 2025
4 checks passed
@danirabbit danirabbit deleted the lenemter/add-system-daemon-applications branch June 10, 2025 19:52
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in OS 9 Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

4 participants