breaking: require Node.js version >= 20.19#1671
Merged
SergeAstapov merged 3 commits intoember-learn:mainfrom May 2, 2025
Merged
breaking: require Node.js version >= 20.19#1671SergeAstapov merged 3 commits intoember-learn:mainfrom
SergeAstapov merged 3 commits intoember-learn:mainfrom
Conversation
…rser issue - Reported in ember-learn#1669
- Without this the CI fails, because it installs incorrect dependencies
- Fixes ember-learn#1669 Caused by: ``` require() of ES Module .../.pnpm/@handlebars+parser@file+..+handlebars-parser/node_modules/@handlebars/parser/dist/cjs/index.js not supported. Instead change the require of index.js in null to a dynamic import() which is available in all CommonJS modules. ``` When using older node in consuming app.
MichalBryxi
force-pushed
the
mb/1669-document-node-requirement
branch
from
2aa71d3 to
610a78d
Compare
This was referenced Apr 17, 2025
SergeAstapov
approved these changes
Apr 23, 2025
| }, | ||
| "engines": { | ||
| "node": ">= 18" | ||
| "node": ">= 20.19" |
Collaborator
There was a problem hiding this comment.
@MichalBryxi why not
Suggested change
| "node": ">= 20.19" | |
| "node": ">= 20.x" |
Contributor
Author
There was a problem hiding this comment.
Anything below 20.19 results in following error in consuming app for me:
> docs-app-for-ember-intl@1.5.6 start /Users/michal/ember/ember-intl/docs/ember-intl
> ember serve
require() of ES Module /Users/michal/ember/ember-intl/node_modules/.pnpm/@handlebars+parser@file+..+handlebars-parser/node_modules/@handlebars/parser/dist/cjs/index.js not supported.
Instead change the require of index.js in null to a dynamic import() which is available in all CommonJS modules.
Stack Trace and Error Report: /var/folders/8q/yrjx_8s115q43r8w5qd90_m00000gn/T/error.dump.09dfcadbf87770bc232cc47d14bf82ae.log
ELIFECYCLE Command failed with exit code 1.
node --version
v20.18.0
IDK how to signify that the consuming app should have certain node version, but sounds reasonable to impose minimal node version also on this repo to not bump into the same set of issues in, say, the testing app (which I think is actually happening).
Related Discord convo.
Contributor
Author
There was a problem hiding this comment.
Ah yeah, this addon's CI itself is having issue with node < 20.19: https://github.com/ember-learn/ember-cli-addon-docs/actions/runs/14612606117/job/40993520690?pr=1672 (different PR that does not have these patches)
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 18.x | ||
| node-version: 20.19.x |
Collaborator
There was a problem hiding this comment.
why not
Suggested change
| node-version: 20.19.x | |
| node-version: 20.x |
so it could be get latest v20 shuld there be any fixes/new versions available
SergeAstapov
changed the title
SergeAstapov
changed the title
10 tasks
Contributor
Author
|
Humble ping @SergeAstapov |
SergeAstapov
approved these changes
May 2, 2025
Collaborator
|
Thank you @MichalBryxi! |
derrabauke
added a commit
to derrabauke/ember-caluma
that referenced
this pull request
Nov 5, 2025
There is an incompatibility with the two packages: * ember-learn/ember-cli-addon-docs#1671 * ember-learn/ember-cli-addon-docs#1669 * https://github.com/handlebars-lang/handlebars-parser/releases/tag/v2.2.1-%40handlebars%2Fparser
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caused by:
When using older node in consuming app.
This PR is based on the actual fix PR for this very repo << it should be reviewed & accepted first. This is just to make sure the build will be green. I can retarget separately if it makes it easier to read.