fix: default adminPages and dashboardWidgets to empty arrays in manifest#357
Open
Vallhalen wants to merge 2 commits intoemdash-cms:mainfrom
Open
fix: default adminPages and dashboardWidgets to empty arrays in manifest#357Vallhalen wants to merge 2 commits intoemdash-cms:mainfrom
Vallhalen wants to merge 2 commits intoemdash-cms:mainfrom
Conversation
When a plugin descriptor has `adminPages` or `adminWidgets` set to `undefined` (e.g. not declared), the manifest passes `undefined` to the admin UI, which then crashes with "Cannot read properties of undefined (reading 'map')" when iterating over them. This applies the `?? []` fallback in all three code paths that populate the manifest: node_modules plugins, sandboxed (standard format) plugins, and marketplace plugins. Fixes emdash-cms#355
🦋 Changeset detectedLatest commit: e765677 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?? []fallback foradminPagesanddashboardWidgetsin all three manifest code paths (node_modules plugins, sandboxed plugins, marketplace plugins)Context
While debugging a separate plugin bug (wrong Block Kit property name), we discovered that
emdash-runtime.tspassesundefinedto the admin manifest when plugins omitadminPages/adminWidgets. The admin components (Sidebar.tsx,Dashboard.tsx) already guard withif (config.adminPages && ...), but this defensive fix ensures the manifest always contains arrays.Changes
One file:
packages/core/src/emdash-runtime.ts— 6 lines changed (3 locations)Test plan
adminPagesadminPages🤖 Generated with Claude Code