Skip to content

fix: default adminPages and dashboardWidgets to empty arrays in manifest #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ascorbic merged 3 commits into from
Apr 11, 2026
+11 −6
Merged

fix: default adminPages and dashboardWidgets to empty arrays in manifest #357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
add8a59
fix: default adminPages and dashboardWidgets to empty arrays in manifest
Vallhalen Apr 7, 2026
e765677
Add changeset for plugin admin pages fix
Vallhalen Apr 8, 2026
1c28d47
Merge branch 'main' into fix/plugin-admin-pages-undefined
ascorbic Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-plugin-admin-pages.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"emdash": patch
---

Fix: default adminPages and dashboardWidgets to empty arrays in manifest to prevent admin UI crash when plugins omit these properties.
12 changes: 6 additions & 6 deletions packages/core/src/emdash-runtime.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,8 +1244,8 @@ export class EmDashRuntime {
version: plugin.version,
enabled,
adminMode,
adminPages: plugin.admin?.pages,
dashboardWidgets: plugin.admin?.widgets,
adminPages: plugin.admin?.pages ?? [],
dashboardWidgets: plugin.admin?.widgets ?? [],
portableTextBlocks: plugin.admin?.portableTextBlocks,
fieldWidgets: plugin.admin?.fieldWidgets,
};
Expand All @@ -1267,8 +1267,8 @@ export class EmDashRuntime {
enabled,
sandboxed: true,
adminMode: hasAdminPages || hasWidgets ? "blocks" : "none",
adminPages: entry.adminPages,
dashboardWidgets: entry.adminWidgets,
adminPages: entry.adminPages ?? [],
dashboardWidgets: entry.adminWidgets ?? [],
};
}

Expand All @@ -1290,8 +1290,8 @@ export class EmDashRuntime {
enabled,
sandboxed: true,
adminMode: hasAdminPages || hasWidgets ? "blocks" : "none",
adminPages: pages,
dashboardWidgets: widgets,
adminPages: pages ?? [],
dashboardWidgets: widgets ?? [],
};
}

Expand Down
Loading