Skip to content

fix(desktop): remove accidental project tabs rollout#3008

Closed
SivanCola wants to merge 2 commits into
esengine:main-v2from
SivanCola:codex/revert-2928-extra-desktop-tabs
Closed

fix(desktop): remove accidental project tabs rollout#3008
SivanCola wants to merge 2 commits into
esengine:main-v2from
SivanCola:codex/revert-2928-extra-desktop-tabs

Conversation

@SivanCola
Copy link
Copy Markdown
Collaborator

Summary

  • remove the desktop project tab rollout from feat(desktop): update Skill page and CLI /skills picker #2928, including tab persistence, project tree, and context panel surfaces
  • keep the Skill page source management UI and the CLI /skills picker intact
  • preserve unrelated main-v2 desktop behavior such as MCP auth diagnosis/clearing, codegraph config status, file-ref search, persistent approvals, and macOS chrome handling

Validation

  • npm run typecheck in desktop/frontend
  • npm run build in desktop/frontend
  • go test ./... in desktop
  • env HOME=/tmp/reasonix-codex-test-home-revert-2928 REASONIX_LANG=en go test ./internal/cli ./internal/config ./internal/control
  • rg -n "WorkspaceTab|ListTabs|OpenProjectTab|OpenGlobalTab|SetActiveTab|CloseTab|ContextPanel|TabBar|ProjectTree|ProjectNode|TopicMeta|CreateTopic|tabId|context inspector|project tab" desktop internal -g '*.go' -g '*.ts' -g '*.tsx' returned no matches

@github-actions github-actions Bot added the v2 Go rewrite (1.x) — main-v2 branch, active development label Jun 4, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5997e8c37f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/settings_app.go Outdated
Comment thread desktop/settings_app.go
@esengine
Copy link
Copy Markdown
Owner

esengine commented Jun 4, 2026

Agreed on dropping the unfinished tabs before release — thanks @SivanCola. Carried this forward in #3011, rebased onto current main-v2, but the raw revert re-undid two fixes that landed on top of #2928: it reverted #3003's model-switch hardening (SetModel back to close-before-build → dead controller on a failed switch) and stripped #2997's macOS window chrome from the frontend. #3011 keeps your tab removal and restores both (plus preserves #3009). Closing in favor of it.

@esengine esengine closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants