fix(desktop): remove accidental project tabs rollout (clean revert)#3011
Merged
Conversation
The tabs revert reintroduced regressions for fixes that landed on top of #2928: - SetModel closed the controller before boot.Build, so a failed switch left a dead controller (regressed #3003); restore build→swap→close and io.Discard for boot diagnostics, and surface the failure in the UI. - The macOS window chrome (#2997) was stripped from the frontend; restore Platform() wiring (bridge.ts), the data-platform/chrome layer (App.tsx), and the darwin-only CSS (minus the removed workspace-tabs-bar rule).
github-actions
Bot
added
the
v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #3008 by @SivanCola — removes the half-finished project-tabs rollout that #2928 accidentally shipped (the real feature is tracked in the #2925 draft), so it doesn't reach production unfinished. Rebased onto current main-v2 and corrected so it doesn't undo fixes that landed on top of #2928.
What it removes
The desktop project-tab surface from #2928: per-tab controllers (WorkspaceTab/tabs.go), project tree, context panel, tab bar — back to a single-controller desktop. Keeps the Skill page source management, CLI
/skillspicker, MCP auth diagnosis, codegraph status, file-ref search, persistent approvals. Nointernal/changes (workspace-root plumbing the CLI + #2991 rely on stays).Regressions in the raw #3008 that this fixes
SetModelto close-before-build (a failed switch left a dead controller) and dropped error surfacing + quiet boot stderr. Restored build→swap→close +io.DiscardinSetModel/rebuild, and thelocal_noticeon failure inuseController.Platform(), App.tsxdata-platform/mac-window-chrome, darwin CSS). Restored, minus the.workspace-tabs-barrule (that element is gone).Verification
gofmtclean (CRLF-only flags on Windows checkout),go build ./...+ fullgo test ./...(desktop module) greenpnpm run typecheck+pnpm run buildcleanCloses #3008