grammar fix pt-BR.json#348
Merged
Merged
Conversation
* changed "estã instalado" to "está instalado" ("estã" does not exist, "está" is the correct form.)
* changed "reproduzí-los" to "reproduzi-los" (incorrect accent).
* changed "Isto" to "Isso" ("Isso" is most commonly used in brazilian portuguese.)
Owner
|
FYI i also happened to add new strings to the sysmodule yesterday for an upcoming feature, you can see the diff here 23f4d2c#diff-69fc4e7b22303de3d8302f3049e3611a4dfa89dee170a784b54c2f279a1448b1 If you want to update your translation too you can do so in this pr |
* portuguese and brazilian portuguese translation for the new sysmodule strings used for an upcoming feature
Contributor
Author
|
Done. Added translation support to both portuguese and brazilian portuguese. I can also do it for european spanish if you wish. If so, should I do it in this PR or create a new one? |
Owner
|
Here is fine by me |
* for european spanish * also fixed one typo from portuguese.json
Contributor
Author
|
Done! |
Owner
|
Looks good. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the delay in fixing this, I only recently noticed these small grammar mistakes. Grammar fix for brazilianPortuguese.json has already been done in #345
changed "estã instalado" to "está instalado" ("estã" does not exist, "está" is the correct form.)
changed "reproduzí-los" to "reproduzi-los" (incorrect accent).
changed "Isto" to "Isso" ("Isso" is most commonly used in brazilian portuguese.)