fix(release): Generate and include Sparkle EdDSA signatures in appcast#109
Merged
Conversation
The release workflow signed the app with Apple codesign but never generated
a Sparkle EdDSA signature for the update ZIP. The app has SUPublicEDKey
configured, so Sparkle requires a valid signature and rejects updates with
"improperly signed and could not be validated".
- release.yml: after zip creation, runs sign_update with SPARKLE_PRIVATE_KEY
secret and uploads the signature as TermQ-{VERSION}.zip.sig release asset
- generate-appcast.sh: fetches the .zip.sig asset from GitHub releases and
includes sparkle:edSignature in each appcast enclosure element
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.ymlthat runssign_updatewith theSPARKLE_PRIVATE_KEYsecret and uploadsTermQ-{VERSION}.zip.sigas a release assetgenerate-appcast.shto fetch the.zip.sigasset from the GitHub release and includesparkle:edSignaturein each appcast<enclosure>elementRoot cause
The app has
SUPublicEDKeyconfigured inInfo.plist, so Sparkle requires a valid EdDSA signature on every update. The release workflow was signing the app bundle with Apple codesign but never generating a Sparkle EdDSA signature for the ZIP. The appcast had nosparkle:edSignatureattribute, causing Sparkle to show "The update is improperly signed and could not be validated."How it works after this fix
release.ymlbuilds the zip, then:echo "$SPARKLE_PRIVATE_KEY" | sign_update --ed-key-file - -p TermQ-{VERSION}.zip > TermQ-{VERSION}.zip.sig.zip.sigfile is uploaded as a release asset alongside the DMG and ZIPgenerate-appcast.shfinds the.zip.sigasset via the GitHub API, fetches it, and writessparkle:edSignature="..."into the appcast enclosureTest plan
TermQ-{VERSION}.zip.sigappears in GitHub release assetssparkle:edSignaturepopulated🤖 Generated with Claude Code