Upgrade Optuna from v2.x.x to v3.0.0 by keisuke-umezawa · Pull Request #2360 · facebookresearch/hydra

keisuke-umezawa · 2022-08-29T08:23:39Z

Motivation

(Write your motivation for proposed changes here.)
To upgrade Optuna from v2.x.x to v3.0.0

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

(How should this PR be tested? Do you require special setup to run the test or repro the fixed bug?)

By the existing unit tests

Related Issues and PRs

(Is this PR part of a group of changes? Link the other relevant PRs and Issues here. Use https://help.github.com/en/articles/closing-issues-using-keywords for help on GitHub syntax)
Fixes #2162

keisuke-umezawa · 2022-08-29T08:45:11Z

Seems that the lint fails even for the main https://app.circleci.com/pipelines/github/facebookresearch/hydra/14763/workflows/e495a59a-f45c-4531-a51a-898dad566d50/jobs/146566

Jasha10

Thanks @keisuke-umezawa!
Do you expect that this change to the optuna sweeper plugin will be backwards compatible for Hydra users?
Could you please bump the version in hydra_optuna_sweeper/hydra_plugins/hydra_optuna_sweeper/__init__.py to "1.3.0.dev0"?

keisuke-umezawa · 2022-09-19T07:24:43Z

@Jasha10

Thank you for your comment!

Do you expect that this change to the optuna sweeper plugin will be backwards compatible for Hydra users?

If the meaning of the backwards compatibility here is that we can run hydra with both Optuna v2.x and v3.x, we should not merge this PR. This code change can run only with Optuna v3.x.

As Optuna will keep the backwards compatibility for a while, e.g. until v4, we do not need to merge this PR at the moment. But, in that case, one note is that someone needs to merge this PR when Optuna will totally break the backwards compatibility.

Jasha10 · 2022-09-20T14:49:10Z

Do you expect that this change to the optuna sweeper plugin will be backwards compatible for Hydra users?

If the meaning of the backwards compatibility here is that we can run hydra with both Optuna v2.x and v3.x ...

My question is about the Optuna Sweeper's user API: will Hydra users need to update their yaml configs?
I think the answer is no; users will not need to update anything.

This code change can run only with Optuna v3.x.

This is fine :)
If users need Optuna v2.x, they can use an old version of the optuna sweeper plugin.
Edit: We are looking into usage patterns to see whether Optuna v3.x is as popular as v2.x. If not, we might delay merging this PR for a while...

Jasha10 · 2022-09-20T14:49:34Z

I will push some commits to this PR branch to try and make the CI pass.

keisuke-umezawa · 2022-10-02T06:07:59Z

Do you expect that this change to the optuna sweeper plugin will be backwards compatible for Hydra users?

If the meaning of the backwards compatibility here is that we can run hydra with both Optuna v2.x and v3.x ...

My question is about the Optuna Sweeper's user API: will Hydra users need to update their yaml configs?
I think the answer is no; users will not need to update anything.

Your understanding is correct. They do not need to change it.

This code change can run only with Optuna v3.x.

This is fine :)
If users need Optuna v2.x, they can use an old version of the optuna sweeper plugin.
Edit: We are looking into usage patterns to see whether Optuna v3.x is as popular as v2.x. If not, we might delay merging this PR for a while...

Thank you! You can merge it when it is appropriate.

AlexLup · 2023-03-09T15:51:27Z

It is possibile to install using pip a dev version of hydra sweeper with support for optuna 3 ?

classner · 2023-03-18T01:53:59Z

Could this please be merged? The 2.1 version of Optuna is very much out-of-date.

AntonClaesson · 2023-04-11T06:16:10Z

I'd also like this to be merged!

keisuke-umezawa · 2023-05-29T09:22:21Z

@Jasha10
Long time no see and thank you for working on it!
Should I do anything to merge this PR to fix CI?

…r/_impl.py Co-authored-by: Jasha10 <8935917+Jasha10@users.noreply.github.com>

Jasha10 · 2023-06-01T22:27:29Z

Hi @keisuke-umezawa,

Since it's been a while, it would be good to rebase this diff on top of the main branch.

Currently I'm no longer an official maintainer of Hydra. That being said, I do hope this diff can be merged at some point.

Jasha10 · 2023-06-01T22:32:14Z

@AlexLup

It is possibile to install using pip a dev version of hydra sweeper with support for optuna 3 ?

You can pip-install the version of hydra-optuna-sweeper from this PR

pip install 'git+https://github.com/keisuke-umezawa/hydra/@feature/fix-optuna-v3#egg=hydra-optuna-sweeper&subdirectory=plugins/hydra_optuna_sweeper'

Or you can git-clone the repo, check out @keisuke-umezawa's feature/fix-optuna-v3 branch, and run pip install --editable . in the plugins/hydra_optuna_sweeper subdirectory of the repo.

keisuke-umezawa · 2023-06-28T09:31:49Z

@Jasha10
Sorry for being late. I rebased it against the current main branch.
Who should I talk with to merge this PR?

Jasha10 · 2023-07-01T22:17:02Z

No problem @keisuke-umezawa. I believe that @omry and @shagunsodhani are current maintainers of Hydra.

I believe the CI failures here are unrelated to this diff. Once #2692 and #2693 are fixed, it should be possible to get the CI green.

t-schanz · 2023-07-24T07:06:20Z

Are there any updates on this? It seems the issues mentioned by @Jasha10 are all merged. I would love to use optuna >= 3 .

odelalleau · 2023-07-24T11:37:09Z

Are there any updates on this? It seems the issues mentioned by @Jasha10 are all merged. I would love to use optuna >= 3 .

In the meantime you should be able to install a version with the fix with the command in #2360 (comment)

Zhylkaaa · 2024-07-20T03:10:03Z

I would like to bump this PR :)
Lack of optuna>=3 starts to become problematic since introduction of new pandas version, I need to have 2 separate envs to extract my data (with pandas) and one for actuall sweeps with older version of SQLAlchemy (optuna<3 relies on older SQLAlchemy incompatible with new pandas)

Can I help with any requested changes?

michaelriedl · 2024-12-01T21:29:30Z

            n_items = (distribution.high - distribution.low) // distribution.step
            return [distribution.low + i * distribution.step for i in range(n_items)]
-        elif isinstance(distribution, DiscreteUniformDistribution):
+        elif isinstance(distribution, FloatDistribution):


This logic is still bugged. There is another check that needs to be done in addition to fixing the reference to q below which is now step.

breznak · 2025-10-09T08:34:27Z

ping after 1 year, @omry any chance to get this merged upstream, please?

nefario7 · 2025-10-10T03:09:04Z

Sorry for spamming, but @omry if you take a look at this and help get this merged, that will be really helpful!

Zhylkaaa · 2025-10-10T16:34:03Z

meanwhile there is another PR to bump the version to 4 xD
#3046

omry · 2026-05-16T02:12:22Z

Closing as superseded by newer Optuna upgrade work, including #3046. This 2022 branch is too stale to use as the basis for the current Optuna plugin update.

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 29, 2022

Jasha10 requested changes Sep 6, 2022

View reviewed changes

Comment thread plugins/hydra_optuna_sweeper/hydra_plugins/hydra_optuna_sweeper/_impl.py Outdated

Jasha10 mentioned this pull request Sep 20, 2022

CI for Upgrade Optuna from v2.x.x to v3.0.0 #2360 #2389

Closed

Jasha10 mentioned this pull request Feb 8, 2023

[Bug] optuna depending on deprecated feature in sqlalchemy. #2562

Open

himkt mentioned this pull request May 25, 2023

Upgrading Optuna from v2.x.x to v3.0.0 #2162

Closed

keisuke-umezawa and others added 2 commits June 1, 2023 22:22

Update optuna to v3

87de89c

Update plugins/hydra_optuna_sweeper/hydra_plugins/hydra_optuna_sweepe…

0bf382b

…r/_impl.py Co-authored-by: Jasha10 <8935917+Jasha10@users.noreply.github.com>

keisuke-umezawa force-pushed the feature/fix-optuna-v3 branch from ac16bc5 to 900dbff Compare June 28, 2023 09:30

shagunsodhani requested a review from Jasha10 July 24, 2023 22:12

keisuke-umezawa force-pushed the feature/fix-optuna-v3 branch from 900dbff to 0bf1a98 Compare December 3, 2023 08:51

ItIsI-Orient mentioned this pull request Dec 4, 2023

{data, tools}[foss/2023a] Hydra v1.3.2, optuna v2.10.1 easybuilders/easybuild-easyconfigs#19244

Closed

Jasha10 mentioned this pull request Jan 19, 2024

Hydra CI failures #2841

Closed

9 tasks

shchur mentioned this pull request Jan 20, 2024

Fix CI failures #2842

Merged

10 tasks

Jasha10 force-pushed the feature/fix-optuna-v3 branch from 0bf1a98 to 0bf382b Compare February 8, 2024 19:46

Merge branch 'main' into feature/fix-optuna-v3

f4d514f

bump version of hydra-optuna-sweeper

8f97f8b

michaelriedl mentioned this pull request Dec 1, 2024

Add gpsampler #2995

Closed

michaelriedl reviewed Dec 1, 2024

View reviewed changes

Northo mentioned this pull request Jan 14, 2025

[Feature Request] Support Optuna 3.x and 4.x in hydra-optuna-sweeper #3007

Closed

filyp mentioned this pull request Dec 20, 2025

Feature/upgrade optuna 4.2.1 #3046

Open

omry closed this May 16, 2026

Uh oh!

Conversation

keisuke-umezawa commented Aug 29, 2022

Motivation

Have you read the Contributing Guidelines on pull requests?

Test Plan

Related Issues and PRs

Uh oh!

keisuke-umezawa commented Aug 29, 2022

Uh oh!

Jasha10 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

keisuke-umezawa commented Sep 19, 2022

Uh oh!

Jasha10 commented Sep 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Jasha10 commented Sep 20, 2022

Uh oh!

keisuke-umezawa commented Oct 2, 2022

Uh oh!

AlexLup commented Mar 9, 2023

Uh oh!

classner commented Mar 18, 2023

Uh oh!

AntonClaesson commented Apr 11, 2023

Uh oh!

keisuke-umezawa commented May 29, 2023

Uh oh!

Jasha10 commented Jun 1, 2023

Uh oh!

Jasha10 commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keisuke-umezawa commented Jun 28, 2023

Uh oh!

Jasha10 commented Jul 1, 2023

Uh oh!

t-schanz commented Jul 24, 2023

Uh oh!

odelalleau commented Jul 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Zhylkaaa commented Jul 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

michaelriedl Dec 1, 2024

Choose a reason for hiding this comment

Uh oh!

breznak commented Oct 9, 2025

Uh oh!

nefario7 commented Oct 10, 2025

Uh oh!

Zhylkaaa commented Oct 10, 2025

Uh oh!

omry commented May 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Jasha10 left a comment •

edited

Loading

Jasha10 commented Sep 20, 2022 •

edited

Loading

Jasha10 commented Jun 1, 2023 •

edited

Loading

odelalleau commented Jul 24, 2023 •

edited

Loading

Zhylkaaa commented Jul 20, 2024 •

edited

Loading