Update browser check#429
Merged
joedolson merged 6 commits intorelease_1.3.0from Feb 9, 2026
Merged
Conversation
Signed-off-by: Joe Dolson <design@joedolson.com>
Contributor
Signed-off-by: Joe Dolson <design@joedolson.com>
Signed-off-by: Joe Dolson <design@joedolson.com>
Signed-off-by: Joe Dolson <design@joedolson.com>
Signed-off-by: Joe Dolson <design@joedolson.com>
Signed-off-by: Joe Dolson <design@joedolson.com>
Contributor
|
Approving Andy's commits with his consent. |
Ipstenu
approved these changes
Feb 9, 2026
|
Should we add attribution to WP core if we're forking those helpers? Not sure what the right approach is here. |
Member
Author
|
@kasparsd It does make sense; need to figure out exactly what we're attributing to, though. This isn't part of core, so it doesn't make sense to attribute it there. There are only 17 contributors to the repository, however, and it probably wouldn't be difficult to figure out which people specifically to credit for this code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft to fix #239
This PR adds the code used in the browse happy API, with some modifications for our needs.
We could add the images, but I don't feel that they're very necessary.