Non cartesian cases for simple diffusion and the soret effect#74
Draft
rekomodo wants to merge 10 commits into
Draft
Non cartesian cases for simple diffusion and the soret effect#74rekomodo wants to merge 10 commits into
rekomodo wants to merge 10 commits into
Conversation
RemDelaporteMathurin
requested changes
Aug 14, 2024
Contributor
RemDelaporteMathurin
left a comment
There was a problem hiding this comment.
- Spherical cases can only be 1D
- It could be worth adding a few details about the derivation in non-cartesian (mostly the expression of the divergence)
- I think the MMS source isn't valid for the spherical case. I obtained
$S = -6 D$ in the spherical system of coordinates - In the write up the exact solution is
$1 + r^2$ but not in the code block - In cylindrical/spherical one cannot set a BC other than no flux on
$r=0$ boundary because that would be a singularity. I think that in your case specifically, since the gradient is zero on this boundary it works well. But I would have the domain start at$r=1$ .
Collaborator
Author
The same expression from the implementation right? I'll add it at the end. |
1167b8e to
51bfe7d
Compare
Collaborator
Author
|
just rebased the branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#64