Fix Try::Tiny::catch when called as method via namespace pollution#354
Merged
Conversation
When namespace::autoclean doesn't clean up Try::Tiny imports (as in
PerlOnJava's stub), modules like DateTime retain 'catch' in their
namespace. This causes issues when indirect object syntax like
'catch { $dt->truncate(...) }' is parsed as '$dt->truncate(...)->catch()'.
The fix detects when catch() is incorrectly invoked as a method (first
argument is a blessed reference instead of CODE) and throws the expected
'Can't locate object method' error, making tests like DateTime's
t/48rt-115983.t pass.
Generated with [Devin](https://cli.devin.ai/docs)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes DateTime test
t/48rt-115983.twhich verifies thatcatchdoesn't leak into DateTime's namespace.Problem
When
namespace::autocleandoesn't clean up Try::Tiny imports (as in PerlOnJava's stub), modules like DateTime retaincatchin their namespace. This causes issues when indirect object syntax like:catch { $dt->truncate(...) }is parsed as:
The result was
Try::Tiny::catchbeing called with a DateTime object instead of a CODE ref, causing:set_subname requires a CODE referenceSolution
Added detection in
Try::Tiny::catchfor when it's incorrectly invoked as a method (first argument is a blessed reference instead of CODE). It now throws the expected error:Test Plan
./jcpan -t DateTime- 51 tests, 3589 subtests)make)Generated with Devin