Skip to content

Fix Try::Tiny::catch when called as method via namespace pollution #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fglock merged 1 commit into from
Mar 23, 2026
Merged

Fix Try::Tiny::catch when called as method via namespace pollution #354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/main/perl/lib/Try/Tiny.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@ BEGIN {
# Blessed wrapper for catch blocks
sub catch (&;@) {
my ($block, @rest) = @_;

# Detect incorrect method call (e.g., $obj->catch(...) when namespace::autoclean
# didn't clean up Try::Tiny imports). This happens with indirect object syntax:
# "catch { $dt->truncate(...) }" is parsed as "$dt->truncate(...)->catch()"
# when 'catch' is in the invocant's package namespace.
if (ref($block) && ref($block) ne 'CODE') {
my $pkg = ref($block);
croak qq{Can't locate object method "catch" via package "$pkg" (perhaps you forgot to load "$pkg"?)};
}

# Detect bare catch() in void context
croak 'Useless bare catch()' unless wantarray;
# Name the block if we can
Expand Down
Loading