cmetrics: improved Windows support#258
Merged
edsiper merged 1 commit intofluent:masterfrom Mar 21, 2026
Merged
Conversation
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
This was referenced Mar 19, 2026
Contributor
Author
|
Hi @edsiper and @cosmo0920, Is it possible to update CMetrics in https://github.com/fluent/fluent-bit? What is the process (do I need to open PR)? This PR was a part of fluent/fluent-bit#11589 initially, i.e. these changes are needed to support building of Fluent Bit on Windows. Thank you. |
Contributor
Author
|
CMetrics was updated in Fluent Bit within fluent/fluent-bit#11601 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
metric: reduced windows.h include to avoid redeclaration conflicts (fluent/fluent-bit#11472 (comment)).
Refer to explanation of this solution in boostorg/stacktrace#157.