tests: fixed Windows support for cumulative_to_delta test case#11589
Conversation
📝 WalkthroughWalkthroughAdds conditional handling for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can enable review details to help with troubleshooting, context usage and more.Enable the |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66c5528e8b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Marat Abrarov <abrarov@gmail.com>
66c5528 to
da4b352
Compare
|
Hi @cosmo0920,
This PR is not going to build on Windows without CMetrics changes. Is it acceptable? Thank you. |
It depends on @edsiper's decision but we must need to merge the cmetrics' changes at first on paper. |
|
I confirmed that your patch with cmetrics's changes fixes the Windows issue on test case for cumulative_to_delta. |
da4b352 to
52d97c9
Compare
|
da4b352 commit with CMetrics changes (which is copied in fluent/cmetrics#258) was removed from this PR. |
This PR fixes part of issue with building of internal tests on Windows - refer to #11472 (comment). The 2nd part of the fix is located in fluent/cmetrics#258 which after merging needs to be copied (as part of CMetrics library) into this repository.
Testing
Before we can approve your change; please submit the following in a comment:
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Related PRs in other repositories
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.
Summary by CodeRabbit