Conversation
flongford
left a comment
flongford
left a comment
There was a problem hiding this comment.
I've had an overview and tested some functionality of the PyFunction class, but will take a closer look next week.
|
|
||
|
|
||
| cdef class ExpressionType(Expression): | ||
| # Is it ok to let users rely on the Expression.__cinit__. |
There was a problem hiding this comment.
I suppose instantiating objects as Expression base classes makes more sense than abstracting the base class from an existing class...
|
@flongford this should be functional now. |
|
Tests segfault on Travis. I'll investigate |
The bug seems related to copying the DVector in the |
- __cinit__ arguments match with C++ constructor - expose a dim property - remove print statements
- and execute a full set/get item cycle
- updated arguments in initializer - add some dimension checks
|
One idea about the segfault. The Travis testing environment uses acado 1.2.2beta while I am using the latest master on Mac. |
|
Issue identified. It's related to the way |
2 participants
@flongford here is the first steps towards being able to use a CFunction. It's very close, I just need to get a full test running and add error management. Can you do a first review? The naming of the classes and modules definitely needs a second pass.