Skip to content

Add nullable to abbreviation property#85

Merged
jannes-io merged 4 commits into2.2from
abbreviation-nullable
Jan 15, 2026
Merged

Add nullable to abbreviation property#85
jannes-io merged 4 commits into2.2from
abbreviation-nullable

Conversation

@mous13
Copy link
Contributor

@mous13 mous13 commented Jan 15, 2026

No description provided.

@mous13 mous13 changed the base branch from master to 2.2 January 15, 2026 20:09
@mous13 mous13 requested a review from jannes-io January 15, 2026 20:10
@jannes-io
Copy link
Member

Hi @mous13 ,
Thanks for the fix, but I'm not entirely sure how our plugin, and how the PERSCOM API in particular will handle null for this field. Perhaps we should remove the required => false from the form, which will replace the error with a nice validation error message instead.

@jannes-io jannes-io merged commit b3ef4f2 into 2.2 Jan 15, 2026
3 checks passed
@jannes-io jannes-io deleted the abbreviation-nullable branch January 18, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants