Skip to content

Add nullable to abbreviation property #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jannes-io merged 4 commits into from
Jan 15, 2026
Merged

Add nullable to abbreviation property #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59f70fd
add nullable to abbreviation
mous13 Jan 15, 2026
62d062b
makes abbreviation not nullable
mous13 Jan 15, 2026
18a84fd
deleted migration
mous13 Jan 15, 2026
5d7fbc6
Update src/Perscom/Entity/Specialty.php
jannes-io Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Admin/Form/SpecialtyType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ public function buildForm(FormBuilderInterface $builder, array $options): void
])
->add('abbreviation', TextType::class, [
'help' => 'Give this specialty an abbreviation. For example the specialty of a US Infantryman would get the abbreviation of 11B.',
'required' => false,
])
;
}
Expand Down
1 change: 1 addition & 0 deletions src/Perscom/Entity/Specialty.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ class Specialty implements PerscomEntityInterface, SortableEntityInterface

#[ORM\Column(length: 8)]
#[Assert\Length(max: 8)]
#[Assert\NotBlank(allowNull: false)]
private string $abbreviation = '';

public static function getPerscomResource(Perscom $perscom): Batchable|Crudable
Expand Down