Open
Conversation
Signed-off-by: Charlie Huang <charliehuang09@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an Abseil LogSink implementation that forwards Abseil logs into WPILib’s DataLogManager output, and wires it into the existing NetworkTables/log startup path.
Changes:
- Introduces
utils::WpiLogSink(AbseilLogSink) that appends log messages to a WPILibStringLogEntry. - Registers the sink during
utils::StartNetworktables()so logs are captured in the WPILib data log. - Updates
src/utilsCMake target sources to compile the new sink.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/utils/wpi_log_sink.h | Declares the Abseil log sink wrapper targeting WPILib datalog. |
| src/utils/wpi_log_sink.cc | Implements the sink by appending log entries to a StringLogEntry. |
| src/utils/nt_utils.cc | Registers the sink during startup after DataLogManager::Start(). |
| src/utils/CMakeLists.txt | Adds wpi_log_sink.cc to the utils library build. |
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+1
to
+5
| #include <frc/DataLogManager.h> | ||
| #include <networktables/StringTopic.h> | ||
| #include <wpi/DataLog.h> | ||
| #include "absl/log/log.h" | ||
| #include "absl/log/log_sink.h" |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: charliehuang09 <41605449+charliehuang09@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.