Mp 44662 react skill - #55
Merged
Merged
Conversation
aswin-shakthic
requested review from
rapchic and
shivakumar-ashwin
as code owners
July 27, 2026 10:19
Dependency ReviewThe following issues were found:
License Issuesskills/fw-app-dev/assets/templates/react-meta-oauth-skeleton/package.json
OpenSSF Scorecard
Scanned Files
|
Removes duplicate FDK wins check flagged by CodeQL review on PR #55. Co-authored-by: Cursor <cursoragent@cursor.com>
…developers/fw-dev-tools into MP-44662-react-skill
…ario.
- Split Meta (FDK 10.1.0) vs vanilla/serverless (10.0.1) engine guidance in SKILL.md
- Add {{{appclient}}} to react-meta-frontend-skeleton index.html
- Reorder React Router catch-all after /app/demo in all Meta skeletons
- Use meta-init.sh auto-detect (no ide-client arg) in react create/migrate commands
- Add fw-app-dev-49 eval scenario and regex tests for Meta-default routing
Co-authored-by: Cursor <cursoragent@cursor.com>
shivakumar-ashwin
approved these changes
Jul 29, 2026
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds React Meta (DEW) as the default UI stack for fw-app-dev, with vanilla JS + Crayons remaining opt-in when explicitly requested.
MP-44662
What changed
/fdk-react-createand/fdk-react-migrate— scaffold new Meta apps or migrate existing Platform 3.0 vanilla JS apps to React Metareact-meta-patterns.mdc—metaConfig.framework: "react", DEW components/styles, React Router, forbidden Crayons in Meta workflow, optional Tailwind/Vitereferences/react-meta/(DEW, Vite merge, styling, migration checklist, custom HTML, superstack patterns)react-meta-frontend-skeleton,react-meta-hybrid-skeleton,react-meta-oauth-skeletonSKILL.md,app-templates.mdc,app-building-blocking-gates.mdc,freshworks-platform3.mdc,validation-workflow.mdc— React Meta default routing; vanilla skeletons preserved as opt-invite.config.jsrequires FDK 10.1.5+ (docs/engine-matrix.md)installer/src/specs/fw-dev-tools-spec.md— React Meta default called out in non-negotiablesTest plan (local run — 2026-07-28)
cd tests && npm install && npm test— 390 pass, 0 fail, 3 skippedcd installer && npm install && npm test— 130 pass, 0 fail (voluntary; noinstaller/changes in this PR)npm audit --audit-level=highintests/andinstaller/— 0 vulnerabilities eachnpm test; all regex suites passtests/eval-results.json)npm run eval) — not completed in agent session (EPIPE fromcursor agentsubprocess); regex + inline checks cover this PRType of change
SKILL.md, command file, rule file).claude-plugin,.cursor-plugin,.codex-plugin,skills/*/.cursor-plugin)installer/)tests/,installer/tests/)Test checklist
Installer tests (required when
installer/changed)installer/unchanged)Static + regex evals (required for all PRs)
LLM evals (required when
SKILL.md, a command file, or.meta.template.jsonis modified)Behavioral scenarios in
tests/eval/scenarios/*.js(with matching regex checks intests/eval/regex/). Run via:Requires
claudeorcursoron PATH. In an agent session (recommended, no API key): "Run the skill evals".tests/eval/scenarios/(and matchingtests/eval/regex/fw-*.regex.test.mjsfor doc-regression checks) — existing scenarios; no react-specific additionstests/eval-results.json); full Cursor CLI eval blocked by EPIPE in agent sessiontests/eval-results.json(inline-skill-content-check;all-tests-report.htmlnot generated)Repo hygiene (when applicable)
AGENTS.mdrules/commands inventory updated (ifskills/*/rules/orskills/*/commands/changed)tests/TESTING.mdupdated (if eval scenarios added/renamed or layer layout changed) — N/A (no new eval scenarios)docs/engine-matrix.mdupdated (iffw-setuptoolchain pins changed) — Meta FDK/vite notes onlynode scripts/bump-version.mjsrun after rootpackage.jsonversion bump (syncs plugin manifests +SKILL.md) — N/A (no root version bump)Security
npm audit --audit-level=highpasses ininstaller/andtests/Not applicable
installer/— installer test checklist skipped (tests run voluntarily; all pass)tests/andinstaller/)CI (runs on PR automatically)
tests/npm testinstaller/npm test(Node 24)installer/+tests/lockfilesLLM evals and
tests/e2e/e2e.share local / agent session only — not in CI.Eval report
npm test)tests/eval-results.jsoncursor agentsubprocess in agent sessioninstaller/unchangedtests/+installer/Dependency review note: skeleton
package.jsonfiles reference@freshworks/dew-components,@freshworks/dew-styles,react,react-dom, andreact-router-domwith unknown SPDX licenses — expected for template stubs; no high/critical CVEs reported.