Skip to content

[Dependencies]: Update Angular 21#926

Merged
mfaarni merged 21 commits into
mainfrom
DS-651-angular-21
May 25, 2026
Merged

[Dependencies]: Update Angular 21#926
mfaarni merged 21 commits into
mainfrom
DS-651-angular-21

Conversation

@RiinaKuu
Copy link
Copy Markdown
Contributor

@RiinaKuu RiinaKuu commented May 21, 2026

DS-651

  • Updated Angular packages to latest available 21 packages
    • Automatic migration removed "lib": ["ES2021", "dom"] from base tsconfig.json
  • Updated peer dependencies to require at least Angular 21
  • Updated jest which required also:
    • Few new package installs to dev dependencies (jest-environment-jsdom, jsdom)
    • ESLint, TS, and Jest config changes
      • ESLint: Added jest globals for test files so that every .spec does not require explicit jest imports
      • TS: Created new file for resolving the jest globals
      • Jest: Change legacy preset to CommonJS preset
  • New jest-preset-angular version required esbuild and since our CI image installs dependencies from Dockerfile from our package.json it had to be installed as dev dependency in the project as well
  • Some additional clean-ups for TS configs
    • Removed deprecated baseUrl (no longer required for paths)
      • This change required some path fixes in sandbox (internal import paths between workspaces are not allowed anymore)
    • Removed deprecated downlevelIteration (no longer necessary when using "target": "ES2022")
    • Added "rootDir", so that Typescript does not have to infer it
    • In library config, added "include" array and updated "exclude" array, since library should not include all the same paths which are in the base tsconfig.json (which it extends)
  • Removed Zone.js import from Storybook since it is now zoneless by default and caused console warnings

VR tests:

  • There were failures due to Chromium typing race conditions and Chromium was dropping characters during synthetic typing
    • Playwright's keyboard.type did not satisfy the event logic of (at least) the Select component's autocomplete variant and it had to be fixed by manually dispatching the keydown/keyup event pair

Developer's checklist

  • I wrote necessary unit tests
  • I updated Storybook stories and documentation to reflect the latest changes
  • I included visual regression tests for new UI design
  • I tested my implementation with different browsers
  • I checked accessibility according to Web Content Accessibility Guidelines 2.1
  • Together with the reviewer I can confirm that the implementation supports the following screenreader and browser combinations (NVDA + Firefox, VoiceOver + Chrome)

@RiinaKuu RiinaKuu added the breaking change This change is not backwards-compatible label May 21, 2026
@github-actions github-actions Bot temporarily deployed to Documentation for branch DS-651-angular-21 May 21, 2026 12:06 Destroyed
@github-actions github-actions Bot temporarily deployed to Documentation for branch DS-651-angular-21 May 21, 2026 12:53 Destroyed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

Lines Statements Branches Functions
Coverage: 94%
94.82% (13696/14444) 89.28% (1425/1596) 91.08% (531/583)
Coverage Report • (94%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files94.8289.2891.0894.82 
report-only-changed-files is enabled. No files were changed in this commit :)

@github-actions github-actions Bot temporarily deployed to Documentation for branch DS-651-angular-21 May 21, 2026 13:19 Destroyed
@github-actions github-actions Bot temporarily deployed to Documentation for branch DS-651-angular-21 May 22, 2026 07:07 Destroyed
@emilyhernandez emilyhernandez mentioned this pull request May 22, 2026
6 tasks
@github-actions github-actions Bot temporarily deployed to Documentation for branch DS-651-angular-21 May 22, 2026 12:47 Destroyed
@github-actions github-actions Bot temporarily deployed to Documentation for branch DS-651-angular-21 May 25, 2026 06:17 Destroyed
@github-actions github-actions Bot temporarily deployed to Documentation for branch DS-651-angular-21 May 25, 2026 08:32 Destroyed
…ispatches to satisfy component's event logic
@github-actions github-actions Bot temporarily deployed to Documentation for branch DS-651-angular-21 May 25, 2026 10:14 Destroyed
@github-actions github-actions Bot temporarily deployed to Documentation for branch DS-651-angular-21 May 25, 2026 10:20 Destroyed
@RiinaKuu RiinaKuu marked this pull request as ready for review May 25, 2026 10:36
Copy link
Copy Markdown
Contributor

@mfaarni mfaarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works, nice!

@mfaarni mfaarni merged commit 9b55839 into main May 25, 2026
15 checks passed
@mfaarni mfaarni deleted the DS-651-angular-21 branch May 25, 2026 13:14
@github-actions github-actions Bot locked and limited conversation to collaborators May 25, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking change This change is not backwards-compatible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants