Handle unparseable JSON response for API requests#17
Open
stensrud wants to merge 2 commits intogeckoboard:masterfrom
Open
Handle unparseable JSON response for API requests#17stensrud wants to merge 2 commits intogeckoboard:masterfrom
stensrud wants to merge 2 commits intogeckoboard:masterfrom
Conversation
|
With todays problems, this happened again: https://geckoboard.statuspage.io/incidents/ltjvjyt9yts0 Would be good to fix this so meaningful error messages can be seen in case of issues with the api. |
t-o-m-
added a commit
that referenced
this pull request
Nov 8, 2017
fixes issues address here #17 with additional tests
t-o-m-
added a commit
that referenced
this pull request
Nov 8, 2017
fixes issues addressed here #17 with additional tests
t-o-m-
added a commit
that referenced
this pull request
Nov 8, 2017
fixes issues addressed here #17 with additional tests
t-o-m-
added a commit
that referenced
this pull request
Nov 8, 2017
fixes issues addressed here #17 with additional tests
Contributor
|
Thanks for fixing this. I would recommend though that you either log the response body or include it in the error. These things can be very hard to debug when all you have is "Unparseable response" in the error logs. Usually there will be some information in the body, such as a "Gateway failure" or something like that, which helps you understand the nature of the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting these in our production environment. This pull request wraps a try/catch around JSON parsing to avoid uncaught errors crashing the server.