Handle non-JSON response for API requests#18
Merged
Conversation
t-o-m-
changed the title
carlmw
approved these changes
Nov 8, 2017
Contributor
carlmw
left a comment
carlmw
left a comment
There was a problem hiding this comment.
Just a comment around the wording of the fallback error message
lib/api-request.js
Outdated
| const parsedBody = JSON.parse(body); | ||
| cb(null, parsedBody); | ||
| } catch (e) { | ||
| cb(new Error('The response from the server was not a JSON')); |
Contributor
There was a problem hiding this comment.
"The response from the server was not valid JSON" perhaps?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As detailed in #17
This change ensures that we handle errors when parsing badly formatted JSON that come back from the server that would otherwise go uncaught.