Skip to content

"Restart Now" button no longer overflows its container#1018

Open
Luke-Bilhorn wants to merge 3 commits into
mainfrom
1015-update-ready-to-install-box-does-not-behave-nicely-with-resizing
Open

"Restart Now" button no longer overflows its container#1018
Luke-Bilhorn wants to merge 3 commits into
mainfrom
1015-update-ready-to-install-box-does-not-behave-nicely-with-resizing

Conversation

@Luke-Bilhorn
Copy link
Copy Markdown
Contributor

No description provided.

…ide card on narrow widths

Re-laid out the "Update ready to install" card as a centered vertical stack
(icon + title, version, buttons row) so the Restart Now button no longer
overflows the card when the panel is narrow. The Release Notes button now
uses a muted background so it's visually distinct from the card.
@Luke-Bilhorn
Copy link
Copy Markdown
Contributor Author

Before:
image

@Luke-Bilhorn
Copy link
Copy Markdown
Contributor Author

After:
image
image

Copy link
Copy Markdown
Contributor

@LeviXIII LeviXIII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overflow is now gone which is great! The problem now is that the Release Notes button brings up the same modal twice. While you are here, do you mind making a fix for that?

The Release Notes button posts an `openExternal` message, which was
being handled by two separate switch blocks in MainMenuProvider, causing
vscode.env.openExternal to fire twice and showing VS Code's external
URL confirmation modal twice. Remove the duplicate handler from
handleProjectManagerMessage; the primary handler in handleMessage
remains.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Ready to Install box does not behave nicely with resizing

2 participants