Skip to content

"Restart Now" button no longer overflows its container #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Luke-Bilhorn wants to merge 3 commits into
base: main
Choose a base branch
from
Open

"Restart Now" button no longer overflows its container #1018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f11f7e
fix(MainMenu): center update notification and keep Restart button ins…
Luke-Bilhorn Jun 2, 2026
52a8d62
Merge branch 'main' into 1015-update-ready-to-install-box-does-not-be…
LeviXIII Jun 4, 2026
7c22112
fix(mainMenu): open release notes only once
Luke-Bilhorn Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/providers/mainMenu/mainMenuProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -908,17 +908,6 @@ export class MainMenuProvider extends BaseWebviewProvider {
await this.handleInstallUpdate();
break;
}
case "openExternal": {
try {
if (message.url) {
await vscode.env.openExternal(vscode.Uri.parse(message.url));
}
} catch (error) {
console.error("Error opening external URL:", error);
vscode.window.showErrorMessage(`Failed to open URL: ${error}`);
}
break;
}
default:
console.log(`Unhandled command: ${message.command}`);
}
Expand Down
154 changes: 77 additions & 77 deletions webviews/codex-webviews/src/MainMenu/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,90 +559,90 @@ function MainMenu() {
}}
>
<CardContent className="p-4">
<div className="flex items-start gap-4">
<div className="flex-shrink-0">
<div className="flex flex-col items-center text-center gap-3">
<div className="flex items-center justify-center gap-2">
<i
className={`${updateInfo.icon} text-xl`}
style={{ color: "var(--ring)" }}
/>
<h3
className="font-semibold text-sm break-words"
style={{ color: "var(--foreground)" }}
>
{updateInfo.title}
</h3>
</div>
<div className="flex-1 space-y-1">
<div className="flex flex-row flex-wrap items-center justify-between gap-2">
<h3
className="font-semibold text-sm"
style={{ color: "var(--foreground)" }}
>
{updateInfo.title}
</h3>
<div className="flex items-center gap-2 ml-4">
{SHOULD_SHOW_RELEASE_NOTES_LINK && (
<Button
size="sm"
variant="ghost"
onClick={() => {
// Open external URL in default browser
vscode.postMessage({
command: "openExternal",
url: RELEASE_NOTES_URL,
});
}}
disabled={projectState.isCheckingForUpdates}
className="text-xs px-2 py-1 h-7"
>
Release Notes
</Button>
)}
<Button
size="sm"
variant={updateInfo.variant}
onClick={() =>
handleProjectAction(updateInfo.primaryCommand)
}
disabled={
projectState.isCheckingForUpdates ||
projectState.updateState === "downloading" ||
projectState.updateState === "updating"
}
className={`text-xs px-3 py-1 h-7 ${
updateInfo?.isPrimary
? "button-primary"
: "button-outline"
}`}
>
{projectState.isCheckingForUpdates ? (
<>
<i className="codicon codicon-loading codicon-modifier-spin mr-1 text-xs" />
Checking...
</>
) : projectState.updateState === "downloading" ? (
<>
<i className="codicon codicon-loading codicon-modifier-spin mr-1 text-xs" />
Downloading...
</>
) : projectState.updateState === "updating" ? (
<>
<i className="codicon codicon-loading codicon-modifier-spin mr-1 text-xs" />
Installing...
</>
) : (
<>
<i
className={`${updateInfo.icon} mr-1 text-xs`}
/>
{updateInfo.primaryAction}
</>
)}
</Button>
</div>
</div>
{projectState.updateVersion && (
<p
className="text-xs"
style={{ color: "var(--muted-foreground)" }}
{projectState.updateVersion && (
<p
className="text-xs"
style={{ color: "var(--muted-foreground)" }}
>
Version {projectState.updateVersion}
</p>
)}
<div className="flex flex-wrap items-center justify-center gap-2">
{SHOULD_SHOW_RELEASE_NOTES_LINK && (
<Button
size="sm"
variant="secondary"
onClick={() => {
// Open external URL in default browser
vscode.postMessage({
command: "openExternal",
url: RELEASE_NOTES_URL,
});
}}
disabled={projectState.isCheckingForUpdates}
className="text-xs px-2 py-1 h-7"
style={{
backgroundColor: "var(--muted)",
color: "var(--muted-foreground)",
}}
>
Version {projectState.updateVersion}
</p>
Release Notes
</Button>
)}
<Button
size="sm"
variant={updateInfo.variant}
onClick={() =>
handleProjectAction(updateInfo.primaryCommand)
}
disabled={
projectState.isCheckingForUpdates ||
projectState.updateState === "downloading" ||
projectState.updateState === "updating"
}
className={`text-xs px-3 py-1 h-7 ${
updateInfo?.isPrimary
? "button-primary"
: "button-outline"
}`}
>
{projectState.isCheckingForUpdates ? (
<>
<i className="codicon codicon-loading codicon-modifier-spin mr-1 text-xs" />
Checking...
</>
) : projectState.updateState === "downloading" ? (
<>
<i className="codicon codicon-loading codicon-modifier-spin mr-1 text-xs" />
Downloading...
</>
) : projectState.updateState === "updating" ? (
<>
<i className="codicon codicon-loading codicon-modifier-spin mr-1 text-xs" />
Installing...
</>
) : (
<>
<i
className={`${updateInfo.icon} mr-1 text-xs`}
/>
{updateInfo.primaryAction}
</>
)}
</Button>
</div>
</div>
</CardContent>
Expand Down
Loading