ci: read app client-id from vars and drop redundant owner#396
ci: read app client-id from vars and drop redundant owner#396dohernandez merged 1 commit intomainfrom
Conversation
Matches the genlayer-node release workflow pattern: Client ID is a repository variable (not a secret), and owner is omitted since the action defaults to the current repo's owner.
✅ Deploy Preview for genlayer-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughConfiguration changes to GitHub workflow documentation and execution. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Description
Follow-up to #395. Aligns the GitHub App token-mint steps in
sync-docs-from-node.ymlwith the working pattern used in the genlayer-node release workflow.Changes
.github/workflows/sync-docs-from-node.yml(both occurrences):client-idsource:${{ secrets.NODE_SYNC_APP_CLIENT_ID }}→${{ vars.NODE_SYNC_APP_CLIENT_ID }}(Client IDs are not sensitive and belong in repository variables).owner: genlayerlabs—actions/create-github-app-tokendefaults to the current repo's owner, so it's redundant when both repos share the same org..github/workflows/README.md: documentsNODE_SYNC_APP_CLIENT_IDas a repository variable (not a secret), whileNODE_SYNC_APP_KEYremains a secret.Required Configuration
NODE_SYNC_APP_CLIENT_ID— repository variableNODE_SYNC_APP_KEY— repository secretSummary by CodeRabbit