Skip to content

ci: read app client-id from vars and drop redundant owner#396

Merged
dohernandez merged 1 commit intomainfrom
ci/sync-docs-github-app
Apr 29, 2026
Merged

ci: read app client-id from vars and drop redundant owner#396
dohernandez merged 1 commit intomainfrom
ci/sync-docs-github-app

Conversation

@dohernandez
Copy link
Copy Markdown
Member

@dohernandez dohernandez commented Apr 29, 2026

Description

Follow-up to #395. Aligns the GitHub App token-mint steps in sync-docs-from-node.yml with the working pattern used in the genlayer-node release workflow.

Changes

  • .github/workflows/sync-docs-from-node.yml (both occurrences):
    • client-id source: ${{ secrets.NODE_SYNC_APP_CLIENT_ID }}${{ vars.NODE_SYNC_APP_CLIENT_ID }} (Client IDs are not sensitive and belong in repository variables).
    • Removed owner: genlayerlabsactions/create-github-app-token defaults to the current repo's owner, so it's redundant when both repos share the same org.
  • .github/workflows/README.md: documents NODE_SYNC_APP_CLIENT_ID as a repository variable (not a secret), while NODE_SYNC_APP_KEY remains a secret.

Required Configuration

  • NODE_SYNC_APP_CLIENT_ID — repository variable
  • NODE_SYNC_APP_KEY — repository secret

Summary by CodeRabbit

  • Chores
    • Updated GitHub Actions workflow configuration to source application credentials more securely, separating client IDs into repository variables while maintaining secret handling for sensitive authentication keys.

Matches the genlayer-node release workflow pattern: Client ID is a repository
variable (not a secret), and owner is omitted since the action defaults to
the current repo's owner.
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 29, 2026

Deploy Preview for genlayer-docs ready!

Name Link
🔨 Latest commit 0660f0b
🔍 Latest deploy log https://app.netlify.com/projects/genlayer-docs/deploys/69f1b22f422e220008264472
😎 Deploy Preview https://deploy-preview-396--genlayer-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ce5ca854-d0c9-42c6-9616-1aba41825598

📥 Commits

Reviewing files that changed from the base of the PR and between d0f3cd1 and 0660f0b.

📒 Files selected for processing (2)
  • .github/workflows/README.md
  • .github/workflows/sync-docs-from-node.yml

📝 Walkthrough

Walkthrough

Configuration changes to GitHub workflow documentation and execution. NODE_SYNC_APP_CLIENT_ID credential source moved from repository secrets to repository variables. The explicit owner: genlayerlabs parameter removed from GitHub App token creation action in two workflow jobs.

Changes

Cohort / File(s) Summary
Documentation Update
.github/workflows/README.md
Reclassifies GitHub App credentials from "Required repository secrets" to "Required configuration," with NODE_SYNC_APP_CLIENT_ID sourced from repository variables instead of secrets.
Workflow Configuration
.github/workflows/sync-docs-from-node.yml
Updates GitHub App token creation to source client-id from repository variables (vars.NODE_SYNC_APP_CLIENT_ID) and removes explicit owner: genlayerlabs parameter from the action in both version-determination and sync-files jobs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • ci: use GitHub App token for node sync workflow #395: Directly related as both PRs modify the same workflow files and GitHub App token configuration for docs syncing; this PR refines the token creation details by moving the client-id source to variables and removing the owner constraint.

Suggested reviewers

  • AgustinRamiroDiaz

Poem

🐰 From secrets vault to variables clear,
A credential migration draws near,
The owner constraint takes its flight,
As workflows sync with renewed might! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: reading the GitHub App client ID from variables and removing the redundant owner parameter.
Description check ✅ Passed The description follows the template structure with clear sections covering changes, rationale, and required configuration; all essential information is provided.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/sync-docs-github-app

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@dohernandez dohernandez merged commit 0518c3a into main Apr 29, 2026
7 checks passed
@dohernandez dohernandez deleted the ci/sync-docs-github-app branch April 29, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant