Skip to content

ci: read app client-id from vars and drop redundant owner #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dohernandez merged 1 commit into from
Apr 29, 2026
Merged

ci: read app client-id from vars and drop redundant owner #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@ Add this to a workflow in the genlayer-node repository:

Access to the private `genlayerlabs/genlayer-node` repository is provided by a GitHub App installed on that repository. The workflow mints a short-lived installation token via `actions/create-github-app-token@v3`.

Required repository secrets:
Required configuration:

- `NODE_SYNC_APP_CLIENT_ID`: Client ID of the GitHub App
- `NODE_SYNC_APP_KEY`: PEM-encoded private key of the GitHub App
- `NODE_SYNC_APP_CLIENT_ID` (repository variable): Client ID of the GitHub App
- `NODE_SYNC_APP_KEY` (repository secret): PEM-encoded private key of the GitHub App

The App must be installed on `genlayerlabs/genlayer-node` with at least `Contents: Read` permission. Tokens are scoped to that single repository at mint time.

Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/sync-docs-from-node.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ jobs:
if: steps.extract.outputs.version == 'latest'
uses: actions/create-github-app-token@v3
with:
client-id: ${{ secrets.NODE_SYNC_APP_CLIENT_ID }}
client-id: ${{ vars.NODE_SYNC_APP_CLIENT_ID }}
private-key: ${{ secrets.NODE_SYNC_APP_KEY }}
owner: genlayerlabs
repositories: genlayer-node

- name: Detect latest version
Expand Down Expand Up @@ -120,9 +119,8 @@ jobs:
id: app-token
uses: actions/create-github-app-token@v3
with:
client-id: ${{ secrets.NODE_SYNC_APP_CLIENT_ID }}
client-id: ${{ vars.NODE_SYNC_APP_CLIENT_ID }}
private-key: ${{ secrets.NODE_SYNC_APP_KEY }}
owner: genlayerlabs
repositories: genlayer-node

- name: Clone source repository
Expand Down
Loading