ci: scope sync jobs to Node Sync environment#397
Conversation
Credentials are stored as environment secrets in the Node Sync environment, so jobs minting the App token must declare environment: Node Sync at the job level. Reverts the client-id source from vars to secrets to match the environment's actual storage.
✅ Deploy Preview for genlayer-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 50 seconds.Comment |
1 participant
Description
Fixes the
Sync Documentation from Node Repositoryworkflow run failures caused by missing credentials at runtime. The App secrets (NODE_SYNC_APP_CLIENT_ID,NODE_SYNC_APP_KEY) are stored in theNode SyncGitHub Environment, so jobs that read them must declareenvironment: Node Syncat the job level — otherwisesecrets.NODE_SYNC_APP_*resolves to empty and the App token mint step receives blank credentials.Changes
.github/workflows/sync-docs-from-node.yml:environment: Node Syncto theprepareandsync-filesjobs (the two jobs that mint the App token).client-idsource from${{ vars.NODE_SYNC_APP_CLIENT_ID }}to${{ secrets.NODE_SYNC_APP_CLIENT_ID }}(both occurrences) — the value is stored as an environment secret in this repo, not a variable..github/workflows/README.md: documents theNode Syncenvironment requirement and lists both credentials as environment secrets.Required Configuration
GitHub Environment:
Node SyncNODE_SYNC_APP_CLIENT_ID(environment secret)NODE_SYNC_APP_KEY(environment secret)Failed run that prompted this fix: https://github.com/genlayerlabs/genlayer-docs/actions/runs/25096528000