(scary) don't save mod jsons if they are fully default#1952
Open
Cvolton wants to merge 4 commits intogeode-sdk:mainfrom
Open
(scary) don't save mod jsons if they are fully default#1952Cvolton wants to merge 4 commits intogeode-sdk:mainfrom
Cvolton wants to merge 4 commits intogeode-sdk:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is scary.
The motivation is primarily Android's power management - with about 180 mods installed saving takes about 3 seconds in the current state, which means there is less time to save the actual GD save file (which the user usually cares about more) before phones kill the app. Moving mod saves after GD introduces the opposite issue though - GD takes ages to save and Geode settings often don't save at all. This PR aims to reduce the time spent on saving mod data which hopefully increases the chance to successfully save normal GD data.
This is a functional implementation primarily made as a proof of concept. My game currently takes 0.28s to save mod data with 182 mods installed on android64 with this implementation.