Skip to content

(scary) don't save mod jsons if they are fully default #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cvolton wants to merge 6 commits into
base: main
Choose a base branch
from
+27 −6
Open

(scary) don't save mod jsons if they are fully default #1952

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
92fe72b
dont save empty jsons
Cvolton Mar 23, 2026
6df1d9c
delete files if empty
Cvolton Mar 23, 2026
4f7910d
dont save settings if theyre all default
Cvolton Mar 23, 2026
107d307
actually make the default value nonsaving work
Cvolton Mar 23, 2026
af3348c
Revert "actually make the default value nonsaving work"
Cvolton Mar 28, 2026
f2fc340
Revert "dont save settings if theyre all default"
Cvolton Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions loader/src/loader/ModImpl.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
#include <system_error>
#include <vector>
#include <string_view>
#include <asp/fs.hpp>

using namespace geode::prelude;

Expand Down Expand Up @@ -240,13 +241,33 @@ Result<> Mod::Impl::saveData() {
// saveData is expected to be synchronous, and always called from GD thread
ModStateEvent(ModEventType::DataSaved, std::move(m_self)).send();

auto res = utils::file::writeStringSafe(m_saveDirPath / "settings.json", json.dump());
if (!res) {
log::error("Unable to save settings: {}", res.unwrapErr());
// TODO: better check if its empty?
auto dump = json.dump();
if(!dump.starts_with("{}")) {
auto res = utils::file::writeStringSafe(m_saveDirPath / "settings.json", dump);
if (!res) {
log::error("Unable to save settings: {}", res.unwrapErr());
}
}
auto res2 = utils::file::writeStringSafe(m_saveDirPath / "saved.json", m_saved.dump());
if (!res2) {
log::error("Unable to save values: {}", res2.unwrapErr());
else {
auto res = asp::fs::remove(m_saveDirPath / "settings.json");
if (!res) {
log::error("Unable to remove settings.json: {}", res.unwrapErr().message());
}
}

dump = m_saved.dump();
if (!dump.starts_with("{}")) {
auto res2 = utils::file::writeStringSafe(m_saveDirPath / "saved.json", m_saved.dump());
if (!res2) {
log::error("Unable to save values: {}", res2.unwrapErr());
}
}
else {
auto res2 = asp::fs::remove(m_saveDirPath / "saved.json");
if (!res2) {
log::error("Unable to remove saved.json: {}", res2.unwrapErr().message());
}
}

return Ok();
Expand Down
Loading