ref(outcomes-routing): check request retention_days#7912
Open
MeredithAnya wants to merge 2 commits intomasterfrom
Open
ref(outcomes-routing): check request retention_days#7912MeredithAnya wants to merge 2 commits intomasterfrom
MeredithAnya wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we initially added the check for 30 days in #7424, it was because we expected that data older than 30days would automatically be routed to be downsampled.
While the default should still be 30days, it's possible in certain scenarios that we would have data for longer than 30days.
So instead of hardcoding 30 days, this allows a request metadata to have
retention_dayspassed through. If not present we will default to 30days forTIER_1(before any additionally downsampling happens based on storage volume)Requires getsentry/sentry-protos#226