Skip to content

ref(outcomes-routing): check request retention_days #7912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MeredithAnya wants to merge 2 commits into
base: master
Choose a base branch
from
+16 −3
Open

ref(outcomes-routing): check request retention_days #7912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60cff89
ref(outcomes-routing): check request retention_days
MeredithAnya Apr 28, 2026
c85555d
check VALID_RETENTION_DAYS
MeredithAnya Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions snuba/web/rpc/storage_routing/routing_strategies/outcomes_based.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
from snuba.query.logical import Query
from snuba.query.query_settings import OutcomesQuerySettings
from snuba.request import Request as SnubaRequest
from snuba.settings import LOWER_RETENTION_DAYS, VALID_RETENTION_DAYS
from snuba.web.query import run_query
from snuba.web.rpc.common.common import (
timestamp_in_range_condition,
Expand Down Expand Up @@ -218,12 +219,24 @@ def _update_routing_decision(

in_msg_meta = extract_message_meta(routing_decision.routing_context.in_msg)

thirty_one_days_ago_ts = int((datetime.now(tz=UTC) - timedelta(days=31)).timestamp())
older_than_thirty_days = thirty_one_days_ago_ts > in_msg_meta.start_timestamp.seconds
if (
in_msg_meta.HasField("retention_days")
and in_msg_meta.retention_days in VALID_RETENTION_DAYS
):
full_fidelity_retention_days = in_msg_meta.retention_days
else:
full_fidelity_retention_days = LOWER_RETENTION_DAYS

full_fidelity_days_ago_ts = int(
(datetime.now(tz=UTC) - timedelta(days=full_fidelity_retention_days + 1)).timestamp()
)
older_than_full_fidelity_days = (
full_fidelity_days_ago_ts > in_msg_meta.start_timestamp.seconds
)

if (
state.get_int_config("enable_long_term_retention_downsampling", 0)
and older_than_thirty_days
and older_than_full_fidelity_days
and in_msg_meta.trace_item_type not in ITEM_TYPE_FULL_RETENTION
):
routing_decision.tier = Tier.TIER_8
Expand Down
Loading