msys2-runtime: clean up fallout from /open pr bug#280
Merged
Conversation
There is currently a bug in `/open pr` where it not only adds the respective parts of the `source` array, but then deletes a large tail of the `PKGBUILD` file, for full details, see git-for-windows/git-for-windows-automation#161 This affected git-for-windows/msys2-runtime#128 and I fixed it manually. However, I failed to realize that the deleted part should have had one crucial edit, namely the part where the new patch is not only added to the sources but also applied... d'oh! Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Member
Author
|
/deploy msys2-runtime The workflow run was started. |
Member
Author
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently a bug in
/open prwhere it not only adds the respective parts of thesourcearray, but then deletes a large tail of thePKGBUILDfile, for full details, see git-for-windows/git-for-windows-automation#161This affected git-for-windows/msys2-runtime#128 and I fixed it manually.
However, I failed to realize that the deleted part should have had one crucial edit, namely the part where the new patch is not only added to the sources but also applied... d'oh!