Substitute all artifacts when the build has the debian_substitution_marker present.#2491
Substitute all artifacts when the build has the debian_substitution_marker present.#2491ser-io wants to merge 1 commit intogoogle:mainfrom
Conversation
ser-io
force-pushed
the
hard-coded-substitution-logic
branch
from
0c242be to
c709553
Compare
ser-io
changed the title
| namespace cuttlefish { | ||
| namespace { | ||
|
|
||
| static constexpr std::string_view kArtifactNames[] = { |
There was a problem hiding this comment.
There's already special logic for --host_substitutions=all:
That implementation scans the bazel/debian package artifacts for files that it can substitute, and aggressively replaces as many as possible. what do you think of using this logic rather than adding a new hardcoded list?
There was a problem hiding this comment.
Based on the discussion in the meeting today it sounds like the preferred strategy is to go with a curated list rather than replacing everything possible.
There was a problem hiding this comment.
The curated list could be "everything in the cvd package". Executables will still be built even if we don't add them there.
There was a problem hiding this comment.
Uses {"all"}. As we have already logic in place to substitute elements listed in the cvd package I agree with using the package as the source of truth rather than having a duplicated logic based on a new hardcoded list.
ser-io
force-pushed
the
hard-coded-substitution-logic
branch
from
c709553 to
4921a5b
Compare
ser-io
force-pushed
the
hard-coded-substitution-logic
branch
from
4921a5b to
7888f96
Compare
ser-io
force-pushed
the
hard-coded-substitution-logic
branch
3 times, most recently
from
5dc408d to
7ca4966
Compare
…arker present. Bug: b/507524719
ser-io
force-pushed
the
hard-coded-substitution-logic
branch
from
7ca4966 to
4a8556a
Compare
3 participants
debian_substitution_marker present.
Bug: b/507524719