test(gax): fix flakiness in BatcherImplTest.testElementsNotLeaking#13572
Merged
Conversation
Increase the timeout and use Awaitility to wait for the background task to complete. This avoids timing out on slower machines (like macOS Intel). TAG=agy CONV=35be4f5a-1538-41fd-9d27-8671b6accae7
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the strict 500ms timeout annotation from the testElementsNotLeaking test and introduces an asynchronous wait using Awaitility before calling future.get(). The reviewer suggests replacing the Awaitility call with a timed future.get(10, TimeUnit.SECONDS) to avoid introducing a new dependency, which is preferred for unblocking CI without adding dependency overhead.
lqiu96
enabled auto-merge (squash)
June 29, 2026 19:29
…x/batching/BatcherImplTest.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
|
jinseopkim0
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase the timeout and use Awaitility to wait for the background task to complete. This avoids timing out on slower machines (like macOS Intel).
Fixes #13565