Skip to content

test(gax): fix flakiness in BatcherImplTest.testElementsNotLeaking #13572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lqiu96 merged 2 commits into from
Jun 29, 2026
Merged

test(gax): fix flakiness in BatcherImplTest.testElementsNotLeaking #13572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a17747d
test(gax): fix flakiness in BatcherImplTest.testElementsNotLeaking
lqiu96 Jun 29, 2026
f52ef0f
Update sdk-platform-java/gax-java/gax/src/test/java/com/google/api/ga…
lqiu96 Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...platform-java/gax-java/gax/src/test/java/com/google/api/gax/batching/BatcherImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,6 @@ void testWhenDelayThresholdExceeds() throws Exception {

/** Validates that the elements are not leaking to multiple batches */
@Test
@Timeout(value = 500, unit = TimeUnit.MILLISECONDS)
void testElementsNotLeaking() throws Exception {
ExecutorService singleThreadExecutor = Executors.newSingleThreadExecutor();
ScheduledExecutorService multiThreadExecutor = Executors.newScheduledThreadPool(20);
Expand Down Expand Up @@ -567,7 +566,7 @@ public ApiFuture<List<Integer>> futureCall(
}

// Closing the resources
future.get();
future.get(10, TimeUnit.SECONDS);
assertThat(isDuplicateElement.get()).isFalse();
singleThreadExecutor.shutdown();
multiThreadExecutor.shutdown();
Expand Down
Loading