Skip to content

fix: use a new managed channel builder when creating channels #13684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mutianf merged 2 commits into from
Jul 7, 2026
+389 −8
Merged

fix: use a new managed channel builder when creating channels #13684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5fbadf
fix: use a new managed channel builder when creating channels
mutianf Jul 7, 2026
f1dd436
rename test
mutianf Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions ...c/main/java/com/google/cloud/bigtable/data/v2/internal/channels/SwitchingChannelPool.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import io.grpc.CallOptions;
import io.grpc.ClientInterceptor;
import io.grpc.ManagedChannel;
import io.grpc.ManagedChannelBuilder;
import io.grpc.MethodDescriptor;
import java.time.Duration;
import java.util.concurrent.ScheduledExecutorService;
Expand Down Expand Up @@ -190,28 +189,30 @@ private ChannelPool newChannelPoolFromProvider(
private ChannelPool newChannelPoolFromProvider(
ChannelProvider channelProvider, String logName, ClientInterceptor... interceptors) {
if (channelProvider.isSingleEndpoint()) {
return new SingleChannelPool(
channelBuilderToSupplier(channelProvider.newChannelBuilder(), interceptors));
return new SingleChannelPool(channelSupplier(channelProvider, interceptors));
}

if (logName != null) {
return new ChannelPoolDpImpl(
channelBuilderToSupplier(channelProvider.newChannelBuilder(), interceptors),
channelSupplier(channelProvider, interceptors),
currentConfiguration,
logName,
metrics.getDebugTagTracer(),
backgroundExecutor);
}

return new ChannelPoolDpImpl(
channelBuilderToSupplier(channelProvider.newChannelBuilder(), interceptors),
channelSupplier(channelProvider, interceptors),
currentConfiguration,
metrics.getDebugTagTracer(),
backgroundExecutor);
}

private Supplier<ManagedChannel> channelBuilderToSupplier(
ManagedChannelBuilder<?> channelBuilder, ClientInterceptor... interceptors) {
return () -> channelBuilder.intercept(interceptors).build();
// Each supplier invocation must produce a fresh ManagedChannelBuilder. Capturing one builder
// and calling .build() on it repeatedly lets anything that mutates the builder between builds
// accumulate — the Nth channel then ships with N copies of that interceptor.
private Supplier<ManagedChannel> channelSupplier(
ChannelProvider channelProvider, ClientInterceptor... interceptors) {
return () -> channelProvider.newChannelBuilder().intercept(interceptors).build();
}
}
Loading
Loading