chore: remove protoc installation in generation check#13717
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
blakeli0
approved these changes
Jul 9, 2026
zhumin8
reviewed
Jul 9, 2026
| This verify check compares the current checked-in files in `java-showcase` against a newly generated client. | ||
|
|
||
| ### Prerequisites (One-time Setup) | ||
| Make sure you have **Go** and **protoc** installed and available in your `PATH` (see the [Requirements](#requirements) section), then run the following setup steps from the repository root: |
Contributor
There was a problem hiding this comment.
fyi - there is a workflow for showcase too.
zhumin8
reviewed
Jul 9, 2026
zhumin8
left a comment
zhumin8
left a comment
Contributor
There was a problem hiding this comment.
LGTM.
There are a few more occurrences.
fyi - I created googleapis/librarian#6720, link this to it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For googleapis/librarian#6558
Fixes googleapis/librarian#6720