Skip to content

chore: remove protoc installation in generation check #13717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeWang1127 merged 6 commits into from
Jul 9, 2026
+1 −10
Merged

chore: remove protoc installation in generation check #13717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca220e5
chore: rm protoc in workflow
JoeWang1127 Jul 9, 2026
e6d78c9
test
JoeWang1127 Jul 9, 2026
86a3b4d
restore trigger
JoeWang1127 Jul 9, 2026
01f0bb3
Merge branch 'main' into chore/rm-protoc
JoeWang1127 Jul 9, 2026
331dae5
update showcase readme
JoeWang1127 Jul 9, 2026
998193a
merge main
JoeWang1127 Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/librarian_generation_check.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,6 @@ jobs:
V=$(go run github.com/googleapis/librarian/cmd/librarian@latest config get version)
echo "Installing librarian version $V"
go install github.com/googleapis/librarian/cmd/librarian@$V
- name: Install protoc
run: |
set -e
VERSION="33.2"
curl -fsSL --retry 5 --retry-delay 15 -o /tmp/protoc.zip "https://github.com/protocolbuffers/protobuf/releases/download/v$VERSION/protoc-$VERSION-linux-x86_64.zip"
cd /usr/local
sudo unzip -o /tmp/protoc.zip
protoc --version
- uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 # v4
with:
java-version: "17"
Expand Down
3 changes: 1 addition & 2 deletions java-showcase/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ the Showcase API which can communicate with a local Showcase server to perform i
## Requirements

* Install [Go](https://go.dev) in your `PATH` (version 1.20 or later).
* Install the [protoc](https://github.com/protocolbuffers/protobuf/releases) compiler in your `PATH`.

## Installing the Server

Expand Down Expand Up @@ -77,7 +76,7 @@ mvn verify -P enable-integration-tests
This verify check compares the current checked-in files in `java-showcase` against a newly generated client.

### Prerequisites (One-time Setup)
Make sure you have **Go** and **protoc** installed and available in your `PATH` (see the [Requirements](#requirements) section), then run the following setup steps from the repository root:

@zhumin8 zhumin8 Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi - there is a workflow for showcase too.

Make sure you have **Go** installed and available in your `PATH` (see the [Requirements](#requirements) section), then run the following setup steps from the repository root:

```shell
# Setup and activate Python virtual environment
Expand Down
Loading